Comments on: Guice it up (or AOP can be made simple sometimes)

By: Willi

Willi — Sun, 17 Jan 2010 12:13:43 +0000

Looks like your are swallowing possible exceptions in your log aspect. Your return statement should be inside the try block and there should be no return in the finally.
But nice article anyway.

By: Kristof Jozsa

Kristof Jozsa — Wed, 25 Nov 2009 17:09:00 +0000

please do me a favour and try to implement the same with aspectj (preferably using its native syntax). others noted the performance issue with this solution but much more generally, I don’t think a DI framework was made for that (aspectj was). I bet you’ll find the code accomplishing the same much easier as well..

By: jponge

jponge — Sun, 08 Nov 2009 17:06:04 +0000

Thanks guys for your useful comments!

However please keep in mind that this is just a quick qnd dirty test of Guice AOP features.

By: jponge

jponge — Sun, 08 Nov 2009 17:05:01 +0000

You are right!